Codecov Report

Merging #1654 into master will increase coverage by 0.96%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1654      +/-   ##
============================================
+ Coverage     67.85%   68.82%   +0.96%     
- Complexity     4042     4088      +46     
============================================
  Files           181      181              
  Lines         16945    16957      +12     
  Branches       2774     2789      +15     
============================================
+ Hits          11498    11670     +172     
+ Misses         4175     4010     -165     
- Partials       1272     1277       +5

@gmshake , please answer questions that are in issue template.

Travis failure looks like unrelated to your change.

It's weird that code style affects coverage.

@gmshake , please answer questions that are in issue template.

@romani Done!

This looks good to me.

@gmshake , do you expect more changes or should this be merged?

this is all that we need.
as this PR merged we will switch chekcstyle's CI back to HEAD master of pgjdbc repo.

@vlsi
No more changes right now. But since Checkstyle 8.28 has not been released yet, all PRs about to be merged should be checked carefully against the style as you mentioned in #1652 (comment)

I think the idea was as follows:

all static imports
---
org.postgresql.**
---
all other
---
java.**
---
javax.**

if any additional changes become required (caused by changes in pgjdbc repo) we will provide PR with fixes after release of checkstyle.

I still highly recommend to use single stable version of checkstyle in pom, to have the same behavior on each contributor locals and in CI.

Indeed. I've switched to 8.27 in d164cba